Quote the variables. (#255)

* Quote the variables.

* test using images without repo url.
This commit is contained in:
Abhilash Raj
2018-07-03 21:27:30 -07:00
committed by GitHub
parent 7500c64167
commit d9c5d6ef95
2 changed files with 7 additions and 7 deletions

View File

@@ -4,9 +4,9 @@ USER=maxking
deploy() { deploy() {
URL=$1 URL="$1"
TAG=$2 TAG="$2"
PASSWORD=$3 PASSWORD="$3"
# Tag the containers correctly. # Tag the containers correctly.
docker tag maxking/mailman-core "$URL/maxking/mailman-core:$TAG" docker tag maxking/mailman-core "$URL/maxking/mailman-core:$TAG"
docker tag maxking/mailman-web "$URL/maxking/mailman-web:$TAG" docker tag maxking/mailman-web "$URL/maxking/mailman-web:$TAG"
@@ -23,5 +23,5 @@ if [ ! "$BRANCH" = "master" ] && [ "$PULL_REQUEST" ]; then
exit 0 exit 0
fi fi
deploy "quay.io" "rolling" $DOCKER_PASSWORD deploy "quay.io" "rolling" "$DOCKER_PASSWORD"
deploy "docker.io" "rolling" $QUAY_PASSWORD deploy "docker.io" "rolling" "$QUAY_PASSWORD"

View File

@@ -13,10 +13,10 @@ version: '2'
services: services:
mailman-core: mailman-core:
image: ${!REG_URL}/maxking/mailman-core:$TAG image: maxking/mailman-core:$TAG
mailman-web: mailman-web:
image: ${!REG_URL}/maxking/mailman-web:$TAG image: maxking/mailman-web:$TAG
environment: environment:
- SECRET_KEY=abcdefghijklmnopqrstuv - SECRET_KEY=abcdefghijklmnopqrstuv
EOF EOF