From d9c5d6ef953874fa479c2c83d3debc4f5c345350 Mon Sep 17 00:00:00 2001 From: Abhilash Raj Date: Tue, 3 Jul 2018 21:27:30 -0700 Subject: [PATCH] Quote the variables. (#255) * Quote the variables. * test using images without repo url. --- .travis/deploy.sh | 10 +++++----- tests/generate_tests.sh | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis/deploy.sh b/.travis/deploy.sh index 0bf6f87..4a4a659 100644 --- a/.travis/deploy.sh +++ b/.travis/deploy.sh @@ -4,9 +4,9 @@ USER=maxking deploy() { - URL=$1 - TAG=$2 - PASSWORD=$3 + URL="$1" + TAG="$2" + PASSWORD="$3" # Tag the containers correctly. docker tag maxking/mailman-core "$URL/maxking/mailman-core:$TAG" docker tag maxking/mailman-web "$URL/maxking/mailman-web:$TAG" @@ -23,5 +23,5 @@ if [ ! "$BRANCH" = "master" ] && [ "$PULL_REQUEST" ]; then exit 0 fi -deploy "quay.io" "rolling" $DOCKER_PASSWORD -deploy "docker.io" "rolling" $QUAY_PASSWORD +deploy "quay.io" "rolling" "$DOCKER_PASSWORD" +deploy "docker.io" "rolling" "$QUAY_PASSWORD" diff --git a/tests/generate_tests.sh b/tests/generate_tests.sh index 9d322e0..58e0f10 100644 --- a/tests/generate_tests.sh +++ b/tests/generate_tests.sh @@ -13,10 +13,10 @@ version: '2' services: mailman-core: - image: ${!REG_URL}/maxking/mailman-core:$TAG + image: maxking/mailman-core:$TAG mailman-web: - image: ${!REG_URL}/maxking/mailman-web:$TAG + image: maxking/mailman-web:$TAG environment: - SECRET_KEY=abcdefghijklmnopqrstuv EOF