fix(idaa): break sys_menu reactive loop + restore menu on iframe=false

Two fixes in the IDAA root layout:

1. Add missing `untrack` import and wrap `$ae_loc.sys_menu.hide = false`
   in `untrack()` inside the trusted-access effect. Without this, reading
   $ae_loc.iframe/$ae_loc.trusted_access and then writing back to $ae_loc
   caused an infinite reactive loop → effect_update_depth_exceeded error.
   Only hit by trusted/admin users in iframe mode (regular Novi members
   at authenticated_access were unaffected).

2. When iframe URL param is explicitly set to 'false', restore
   $ae_loc.sys_menu.hide = false. The root layout sets it to true on
   iframe=true but never resets it, leaving the system bar permanently
   hidden after leaving iframe mode.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Scott Idem
2026-03-25 11:20:44 -04:00
parent 5cd1d3b7ad
commit 1c818e648b

View File

@@ -2,6 +2,7 @@
let log_lvl: number = 0;
// *** Import Svelte specific
import { untrack } from 'svelte';
import { browser } from '$app/environment';
import { afterNavigate } from '$app/navigation';
@@ -202,7 +203,13 @@ $effect(() => {
$ae_loc.iframe = false;
document.getElementsByTagName('html')[0].classList.remove('iframe');
// document.getElementsByTagName('html')[0].classList.add('light');
// data_struct['iframe'] = false;
// WHY: The root layout sets sys_menu.hide=true when iframe=true, but never
// restores it. We restore it here so the system bar reappears when the URL
// param is explicitly set to false (e.g. admin toggling embed mode off).
untrack(() => {
$ae_loc.sys_menu.hide = false;
});
}
});
@@ -211,7 +218,13 @@ $effect(() => {
// the iframe src to pass show_menu=true, so we watch for trusted_access and unhide it.
$effect(() => {
if (browser && $ae_loc.iframe && $ae_loc.trusted_access) {
$ae_loc.sys_menu.hide = false;
// WHY untrack: writing to $ae_loc inside an effect that reads $ae_loc causes
// an infinite reactive loop (effect_update_depth_exceeded). The conditions we
// want to react to ($ae_loc.iframe / trusted_access) are tracked above; the
// write is a side-effect that must not re-trigger this effect.
untrack(() => {
$ae_loc.sys_menu.hide = false;
});
}
});