From f24449457f1a2739c9c4ebba17445b7fbabcf729 Mon Sep 17 00:00:00 2001 From: Scott Idem Date: Mon, 9 Feb 2026 20:22:51 -0500 Subject: [PATCH] refactor: address Svelte compiler warnings and improve a11y/security - Convert decorative labels to spans to fix a11y warnings in Accounts and Sites pages - Add rel="noopener noreferrer" to external links for security - Use untrack for Svelte 5 state initialization from props in e_app_sign_in_out.svelte - Make TipTap editor styles global to fix scoping warnings for dynamic content --- src/lib/ae_core/ae_comp__site_config_editor.svelte | 2 +- src/lib/app_components/e_app_sign_in_out.svelte | 8 ++++---- src/lib/elements/element_tiptap_editor.scss | 2 +- src/routes/core/accounts/+page.svelte | 6 +++--- src/routes/core/contacts/[contact_id]/+page.svelte | 2 +- src/routes/core/sites/+page.svelte | 6 +++--- src/routes/core/sites/[site_id]/+page.svelte | 2 +- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/lib/ae_core/ae_comp__site_config_editor.svelte b/src/lib/ae_core/ae_comp__site_config_editor.svelte index 223454c9..3d059c49 100644 --- a/src/lib/ae_core/ae_comp__site_config_editor.svelte +++ b/src/lib/ae_core/ae_comp__site_config_editor.svelte @@ -117,7 +117,7 @@
{#if cfg_json.header_image_path} - + {/if}
diff --git a/src/lib/app_components/e_app_sign_in_out.svelte b/src/lib/app_components/e_app_sign_in_out.svelte index f7a88528..647355ac 100644 --- a/src/lib/app_components/e_app_sign_in_out.svelte +++ b/src/lib/app_components/e_app_sign_in_out.svelte @@ -37,10 +37,10 @@ let { log_lvl = $bindable(0), data = null, hidden = $bindable(true) }: Props = $props(); - let url_user_id = $state(data?.url?.searchParams?.get('user_id')); - let url_user_key = $state(data?.url?.searchParams?.get('user_key')); // Reminder that "key" is the site's auth key. - let url_user_username = $state(data?.url?.searchParams?.get('username')); - let url_user_email = $state(data?.url?.searchParams?.get('user_email')); + let url_user_id = $state(untrack(() => data?.url?.searchParams?.get('user_id'))); + let url_user_key = $state(untrack(() => data?.url?.searchParams?.get('user_key'))); // Reminder that "key" is the site's auth key. + let url_user_username = $state(untrack(() => data?.url?.searchParams?.get('username'))); + let url_user_email = $state(untrack(() => data?.url?.searchParams?.get('user_email'))); $effect(() => { // NOTE: Sync URL params to state. diff --git a/src/lib/elements/element_tiptap_editor.scss b/src/lib/elements/element_tiptap_editor.scss index 393932e0..c4a8a302 100644 --- a/src/lib/elements/element_tiptap_editor.scss +++ b/src/lib/elements/element_tiptap_editor.scss @@ -1,5 +1,5 @@ /* Basic editor styles */ -.tiptap { +:global(.tiptap) { :first-child { margin-top: 0; } diff --git a/src/routes/core/accounts/+page.svelte b/src/routes/core/accounts/+page.svelte index fda5140a..a7f86db4 100644 --- a/src/routes/core/accounts/+page.svelte +++ b/src/routes/core/accounts/+page.svelte @@ -76,7 +76,7 @@
- + Search Accounts
@@ -99,7 +99,7 @@
- + Status diff --git a/src/routes/core/contacts/[contact_id]/+page.svelte b/src/routes/core/contacts/[contact_id]/+page.svelte index 54a4c5d4..5dac540d 100644 --- a/src/routes/core/contacts/[contact_id]/+page.svelte +++ b/src/routes/core/contacts/[contact_id]/+page.svelte @@ -125,7 +125,7 @@ Website

{#if contact.website_url} - + {contact.website_url} {:else} diff --git a/src/routes/core/sites/+page.svelte b/src/routes/core/sites/+page.svelte index 3251574f..e6a30123 100644 --- a/src/routes/core/sites/+page.svelte +++ b/src/routes/core/sites/+page.svelte @@ -79,7 +79,7 @@
- + Search Sites
@@ -102,7 +102,7 @@
- + Status diff --git a/src/routes/core/sites/[site_id]/+page.svelte b/src/routes/core/sites/[site_id]/+page.svelte index 22140427..0a1fb3e6 100644 --- a/src/routes/core/sites/[site_id]/+page.svelte +++ b/src/routes/core/sites/[site_id]/+page.svelte @@ -212,7 +212,7 @@
{dom.fqdn} - +