From e735d0c213d03b681348e6adef3b3ad2f0639470 Mon Sep 17 00:00:00 2001
From: Scott Idem <stidem@gmail.com>
Date: Tue, 2 Jun 2026 16:48:44 -0400
Subject: [PATCH] refactor(badges): remove redundant loading gate; fix
 BarChart2 deprecation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The +page.svelte {#if search_status=loading && ids.length===0} gate is now
redundant — ae_comp__badge_obj_li handles all states internally (Searching...,
Enter your name, No results). Removing it also fixes a UX regression where
trusted-user IDB fallback results would be hidden by the gate whenever a new
API search fired. Component is now always mounted and manages its own state.

Also replaces deprecated BarChart2 with ChartColumnBig (lucide rename).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../[event_id]/(badges)/badges/+page.svelte   | 20 ++++++-------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/src/routes/events/[event_id]/(badges)/badges/+page.svelte b/src/routes/events/[event_id]/(badges)/badges/+page.svelte
index 66f5943b..821c9ca4 100644
--- a/src/routes/events/[event_id]/(badges)/badges/+page.svelte
+++ b/src/routes/events/[event_id]/(badges)/badges/+page.svelte
@@ -32,7 +32,7 @@ import Comp_badge_obj_li from './ae_comp__badge_obj_li.svelte';
 import Comp_badge_create_form from './ae_comp__badge_create_form.svelte';
 import Comp_badge_upload_form from './ae_comp__badge_upload_form.svelte';
 
-import { LoaderCircle, UserPlus, Printer, Upload, FileText, BarChart2 } from '@lucide/svelte';
+import { UserPlus, Printer, Upload, FileText, ChartColumnBig } from '@lucide/svelte';
 
 // Load templates for this event so the create form can show the selector and
 // derive badge_type_code_li from whichever template the user picks.
@@ -524,7 +524,7 @@ async function handle_search_refresh(params: any) {
             <a
                 href={`/events/${$events_slct?.event_id}/badges/stats`}
                 class="btn btn-tertiary">
-                <BarChart2 size="1em" /> Badge Printing Stats
+                <ChartColumnBig size="1em" /> Badge Printing Stats
             </a>
         </div>
     {/if}
@@ -592,18 +592,10 @@ async function handle_search_refresh(params: any) {
     {/if}
 </dialog>
 
-{#if $events_sess?.badges?.search_status === 'loading' && event_badge_id_li.length === 0}
-    <div
-        class="flex w-full flex-col items-center justify-center p-16 text-center opacity-50">
-        <LoaderCircle size="3em" class="mx-auto mb-2 animate-spin" />
-        <p class="text-xl">Loading badges...</p>
-    </div>
-{:else}
-    <Comp_badge_obj_li
-        {lq__event_badge_obj_li}
-        search_status={$events_sess?.badges?.search_status ?? null}
-        log_lvl={1} />
-{/if}
+<Comp_badge_obj_li
+    {lq__event_badge_obj_li}
+    search_status={$events_sess?.badges?.search_status ?? null}
+    log_lvl={1} />
 
 <style>
 dialog {