Scott.Idem/OSIT-AE-App-Svelte
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: standardize naming conventions to snake_case

Browse Source 
- Rename demo_event_id → testing_event_id (more explicit)
- Rename demo_account_id → testing_account_id (matches convention)
- Rename demo_badge_id → event_badge_id (descriptive)
- Rename demo_template_id → event_badge_template_id (explicit)
- Update all test files for consistency (15 files)
- Enhance README with organized test data sections
- Update person IDs to match README test data
- No regression: 15 tests passing, 7 pre-existing failures unchanged
This commit is contained in:
Scott Idem
2026-02-26 15:43:31 -05:00
parent 2c289e39de
commit a91c648c61
14 changed files with 176 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/event_badge_crud.test.ts
View File

@@ -1,8 +1,8 @@
import { test, expect } from '@playwright/test';
import { ae_app_local_data_defaults } from './_helpers/ae_defaults';
import { demo_event_id, demo_account_id } from './_helpers/env';
import { testing_event_id, testing_account_id } from './_helpers/env';
const test_event_id = demo_event_id;
const test_event_id = testing_event_id; // Why is this here? Just using testing_event_id instead?
test.describe('event_badge_crud (create, find, edit, delete)', () => {
test.beforeEach(async ({ page }) => {
@@ -65,10 +65,10 @@ test.describe('event_badge_crud (create, find, edit, delete)', () => {
page.on('dialog', async (dialog) => { await dialog.accept(); });
await page.addInitScript(({ defaults, eventId, accountId }) => {
const test_data = { ...defaults, account_id: accountId, manager_access: true, administrator_access: true, edit_mode: true, mod: { ...defaults.mod, events: { ...defaults.mod.events, event_id: eventId } } };
await page.addInitScript(({ defaults, event_id, accountId }) => {
const test_data = { ...defaults, account_id: accountId, manager_access: true, administrator_access: true, edit_mode: true, mod: { ...defaults.mod, events: { ...defaults.mod.events, event_id: event_id } } };
window.localStorage.setItem('ae_loc', JSON.stringify(test_data));
}, { defaults: ae_app_local_data_defaults, eventId: test_event_id, accountId: demo_account_id });
}, { defaults: ae_app_local_data_defaults, event_id: test_event_id, accountId: testing_account_id });
});
test('create -> find -> edit -> delete badge', async ({ page }) => {
@@ -101,8 +101,8 @@ test.describe('event_badge_crud (create, find, edit, delete)', () => {
// Find badges via search endpoint (simulate listing page) using in-page fetch
await page.goto(`/events/${test_event_id}/badges`);
const search_json = await page.evaluate(async (eventId) => {
const r = await fetch(`/v3/crud/event/${eventId}/event_badge/search`, { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({}) });
const search_json = await page.evaluate(async (event_id) => {
const r = await fetch(`/v3/crud/event/${event_id}/event_badge/search`, { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({}) });
return await r.json();
}, test_event_id);
expect(Array.isArray(search_json.data)).toBeTruthy();
@@ -110,24 +110,24 @@ test.describe('event_badge_crud (create, find, edit, delete)', () => {
// Edit badge via browser fetch (exercise nested update)
const edit_resp = await page.evaluate(async (args) => {
const { eventId, badgeId } = args;
const r = await fetch(`/v3/crud/event/${eventId}/event_badge/${badgeId}/`, { method: 'PATCH', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ full_name_override: 'Edited User' }) });
const { event_id, event_badge_id } = args;
const r = await fetch(`/v3/crud/event/${event_id}/event_badge/${event_badge_id}/`, { method: 'PATCH', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ full_name_override: 'Edited User' }) });
return { status: r.status, json: await r.json() };
}, { eventId: test_event_id, badgeId: badge_id });
}, { event_id: test_event_id, event_badge_id: badge_id });
expect(edit_resp.status === 200).toBeTruthy();
expect(edit_resp.json.data.full_name_override).toBe('Edited User');
// Delete badge via browser fetch
const del_resp = await page.evaluate(async (args) => {
const { eventId, badgeId } = args;
const r = await fetch(`/v3/crud/event/${eventId}/event_badge/${badgeId}/`, { method: 'DELETE' });
const { event_id, event_badge_id } = args;
const r = await fetch(`/v3/crud/event/${event_id}/event_badge/${event_badge_id}/`, { method: 'DELETE' });
return { status: r.status, ok: r.ok };
}, { eventId: test_event_id, badgeId: badge_id });
}, { event_id: test_event_id, event_badge_id: badge_id });
expect(del_resp.ok).toBeTruthy();
// Confirm search returns no items
const post_delete_json = await page.evaluate(async (eventId) => {
const r = await fetch(`/v3/crud/event/${eventId}/event_badge/search`, { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({}) });
const post_delete_json = await page.evaluate(async (event_id) => {
const r = await fetch(`/v3/crud/event/${event_id}/event_badge/search`, { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({}) });
return await r.json();
}, test_event_id);
expect(Array.isArray(post_delete_json.data)).toBeTruthy();