From 94e4fad061b47b8026d59031b773fe241b0942a9 Mon Sep 17 00:00:00 2001 From: Scott Idem Date: Thu, 11 Jun 2026 15:29:48 -0400 Subject: [PATCH] chore(stores): remove unused default properties from ae_loc, ae_sess, events_slct, idaa_loc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Audited all three legacy persisted-store files for properties with zero references in src/. Removed ~119 lines of dead defaults: - ae_loc: qr_scanner_version, ds, entire mod block (archives/events/journals/posts/sponsorships) - ae_sess: hub, mod block (archives/events/journals/posts/sponsorships/testing), download - events_loc: ds - events_sess: ds_loaded - events_slct: abstract_*, badge_template_*, device_*, exhibit_tracking_*, lq__presenter_obj - idaa_loc: ds, idaa_cfg_json, top-level qry__* (each submodule has its own), novi_rate_limited_until, novi_*_base_url (read from site_cfg_json, not idaa_loc) No version bumps needed — removing fields from defaults is backwards-compatible. svelte-check passes: 0 errors, 0 warnings. Co-Authored-By: Claude Sonnet 4.6 --- src/lib/stores/ae_events_stores.ts | 22 --------- src/lib/stores/ae_idaa_stores.ts | 18 ------- src/lib/stores/ae_stores.ts | 79 ------------------------------ 3 files changed, 119 deletions(-) diff --git a/src/lib/stores/ae_events_stores.ts b/src/lib/stores/ae_events_stores.ts index 5501bf15..8c3a926a 100644 --- a/src/lib/stores/ae_events_stores.ts +++ b/src/lib/stores/ae_events_stores.ts @@ -40,8 +40,6 @@ const events_local_data_struct: key_val = { name: 'Aether - Events', title: `OSIT's Æ Events`, - ds: {}, - events_cfg_json: {}, event_id: null, @@ -102,7 +100,6 @@ const events_session_data_struct: key_val = { ds: { submit_status: null }, - ds_loaded: {}, qry__enabled: 'enabled', // all, disabled, enabled qry__hidden: 'not_hidden', // all, hidden, not_hidden @@ -162,31 +159,14 @@ const events_slct_obj_template: key_val = { event_obj_li: [], // Sub-level event_ - abstract_id: null, - abstract_obj: {}, - abstract_obj_li: [], - badge_id: null, badge_obj: {}, badge_obj_li: [], - badge_template_id: null, - badge_template_obj: {}, - badge_template_obj_li: [], - - device_id: null, - device_obj: {}, - device_obj_li: [], - exhibit_id: null, exhibit_obj: {}, exhibit_obj_li: [], - // Rename these to badge_tracking_*? - exhibit_tracking_id: null, - exhibit_tracking_obj: {}, - exhibit_tracking_obj_li: [], - file_id: null, file_obj: {}, file_obj_li: [], @@ -218,8 +198,6 @@ const events_slct_obj_template: key_val = { session_obj_li: [], event_session_obj: {}, - lq__presenter_obj: {}, // Testing passing a LiveQuery object around... - auth__event_presenter_id: null, auth__event_presentation_id: null }; diff --git a/src/lib/stores/ae_idaa_stores.ts b/src/lib/stores/ae_idaa_stores.ts index cd09b79e..846c1135 100644 --- a/src/lib/stores/ae_idaa_stores.ts +++ b/src/lib/stores/ae_idaa_stores.ts @@ -23,30 +23,12 @@ const idaa_local_data_struct: key_val = { // Timestamp (ms since epoch) when the last successful verification occurred. // Used to cache verification results and avoid repeated Novi API calls. novi_verified_ts: null, - // If set to a ms timestamp, verification attempts should be skipped until this time. - // Used to honor rate-limits and Retry-After behavior. - novi_rate_limited_until: null, // Populated from $ae_loc.site_cfg_json at IDAA layout mount — not managed here. // See routes/idaa/(idaa)/+layout.svelte for the override logic. novi_admin_li: [], novi_trusted_li: [], novi_jitsi_mod_li: [], - novi_archives_base_url: 'https://www.idaa.org/idaa-archives', - novi_bb_base_url: 'https://www.idaa.org/idaa-bulletin-board', - novi_meetings_base_url: 'https://www.idaa.org/idaa-meetings', - - ds: {}, - - idaa_cfg_json: {}, - - // all, disabled, enabled - qry__enabled: 'enabled', - // all, hidden, not_hidden - qry__hidden: 'not_hidden', - qry__limit: 20, - qry__offset: 0, - archives: { enabled: 'enabled', // all, disabled, enabled hidden: 'not_hidden', // all, hidden, not_hidden diff --git a/src/lib/stores/ae_stores.ts b/src/lib/stores/ae_stores.ts index 56d66995..21b85048 100644 --- a/src/lib/stores/ae_stores.ts +++ b/src/lib/stores/ae_stores.ts @@ -91,8 +91,6 @@ const ae_app_local_data_defaults: key_val = { qry__limit: 20, qry__offset: 0, - qr_scanner_version: 'one', - admin: { show_element__sql_qry: false, show_element__sql_qry_results: false @@ -143,7 +141,6 @@ const ae_app_local_data_defaults: key_val = { add_to_use_files_method: 'upload' // upload, select }, - ds: {}, hub: { show_element__cfg: true, show_element__cfg_detail: false, @@ -156,56 +153,6 @@ const ae_app_local_data_defaults: key_val = { qr: {} }, - mod: { - archives: {}, - - events: { - event_id: null, - - show_edit__event_presenter_obj: false, - show_list__event_presenter_obj_li: true, - show_view__event_presenter_obj: false, - - submit_status: null, - - // When set, new presenters are automatically assigned to this session. - default_session_id: null - }, - - journals: {}, - - posts: {}, - - sponsorships: { - cfg_id: null, - - for_type: null, - for_id: null, - - // Max complimentary guests per sponsorship tier (0 = no tier). - // These are fallback defaults; the active event config should override via events_cfg_json. - level_guest_max_li: { - 0: 0, - 1: 4, - 2: 8, - 3: 8, - 4: 8, - 5: 8, - 6: 16, - 7: 16 - }, - - show_edit__sponsorship_obj: false, - show_list__sponsorship_obj_li: true, - show_view__sponsorship_obj: false, - - show_question__accommodations: false, - - submit_status: null // 'saving', 'created', 'updated' - } - - // testing: {}, - } }; export const ae_loc: Writable = persisted( @@ -258,31 +205,6 @@ const ae_app_session_data_defaults: key_val = { clip_complete: null }, - hub: { - show_xyz: null, - account_id_qry_status: null, - event_badge_id_status_qry__search: null, - event_presenter_id_qry_status: null, - site_domain_id_qry_status: null, - sponsorship_id_qry_status: null, - sponsorship_cfg_id_qry_status: null, - - qr: {} - }, - mod: { - archives: {}, - events: {}, - journals: {}, - posts: {}, - sponsorships: { - disable_submit__sponsorship_obj: false, - slct__level_num: 0, - show_question__accommodations: false, - submit_status: null // 'saving', 'created', 'updated', 'saved' - }, - testing: {} - }, - person: { show_report__person_li: false, @@ -291,7 +213,6 @@ const ae_app_session_data_defaults: key_val = { show__modal_change_password: false, - download: {}, // Per-file progress keyed by file_id (downloads) or temp_id (uploads). // Shape: { status, endpoint, filename, size_total, size_loaded, percent_completed } api_download_kv: {},