Scott.Idem/OSIT-AE-App-Svelte
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(idaa): preserve default sound mute settings when URL params absent

Browse Source 
Unconditional assignment was overwriting $state defaults (incoming msg,
reactions, raise hand all muted) with false whenever the iframe template
didn't pass the sound URL params — which it never does.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Scott Idem
2026-03-31 19:04:11 -04:00
parent f1bce485ab
commit 8fabaf28f7
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/routes/idaa/(idaa)/video_conferences/+page.svelte
View File

@@ -429,14 +429,19 @@ async function fetch_novi_data() {
room_name = url_params.room ?? 'Default-Room';
domain = url_params.domain ?? 'jitsi.dgrzone.com';
// Initialize sound settings from URL params
disable_incoming_msg_sound = url_params.incoming_msg_sound === 'true';
disable_participant_joined_sound =
url_params.participant_joined_sound === 'true';
disable_participant_left_sound =
url_params.participant_left_sound === 'true';
disable_reaction_sound = url_params.reaction_sound === 'true';
disable_raise_hand_sound = url_params.raise_hand_sound === 'true';
// Override sound defaults from URL params only when explicitly provided.
// If the param is absent (null), keep the $state defaults — the iframe template
// does not pass these params, so unconditional assignment would wipe out the defaults.
if (url_params.incoming_msg_sound !== null)
disable_incoming_msg_sound = url_params.incoming_msg_sound === 'true';
if (url_params.participant_joined_sound !== null)
disable_participant_joined_sound = url_params.participant_joined_sound === 'true';
if (url_params.participant_left_sound !== null)
disable_participant_left_sound = url_params.participant_left_sound === 'true';
if (url_params.reaction_sound !== null)
disable_reaction_sound = url_params.reaction_sound === 'true';
if (url_params.raise_hand_sound !== null)
disable_raise_hand_sound = url_params.raise_hand_sound === 'true';
if (log_lvl) {
console.log(