From 60ca3b2f6c9b0e701e60864cbaa8879605fd241d Mon Sep 17 00:00:00 2001 From: Scott Idem Date: Wed, 11 Mar 2026 15:42:58 -0400 Subject: [PATCH] fix: update docs/todos after v1 edit form retirement + v2 rename - Update CLIENT__IDAA_and_customized_mods.md: remove v1 entry and v2 suffix - Update tests/README.md: rename _v2 reference to canonical filename - Update TODO__Agents.md: mark all state_referenced_locally warnings resolved; document remaining 23 CSS @apply warnings as harmless language-service noise --- .../CLIENT__IDAA_and_customized_mods.md | 5 +- documentation/TODO__Agents.md | 2 +- .../recovery_meetings/[event_id]/+page.svelte | 2 +- .../ae_idaa_comp__event_obj_id_edit.svelte | 3513 ++++++----------- .../ae_idaa_comp__event_obj_id_edit_v2.svelte | 2014 ---------- tests/README.md | 2 +- 6 files changed, 1211 insertions(+), 4327 deletions(-) delete mode 100644 src/routes/idaa/(idaa)/recovery_meetings/ae_idaa_comp__event_obj_id_edit_v2.svelte diff --git a/documentation/CLIENT__IDAA_and_customized_mods.md b/documentation/CLIENT__IDAA_and_customized_mods.md index 21fb72b7..a1b53497 100644 --- a/documentation/CLIENT__IDAA_and_customized_mods.md +++ b/documentation/CLIENT__IDAA_and_customized_mods.md @@ -81,8 +81,7 @@ src/routes/idaa/ │ │ ├── ae_idaa_comp__event_obj_li.svelte # Individual list item card │ │ ├── ae_idaa_comp__event_obj_qry.svelte # Query/filter bar │ │ ├── ae_idaa_comp__event_obj_id_view.svelte # Meeting detail (read-only) -│ │ ├── ae_idaa_comp__event_obj_id_edit.svelte # Meeting edit form (v1, legacy — do not touch) -│ │ ├── ae_idaa_comp__event_obj_id_edit_v2.svelte # Meeting edit form (v2, active) +│ │ ├── ae_idaa_comp__event_obj_id_edit.svelte # Meeting edit form (active) │ │ └── [event_id]/ │ │ ├── +page.svelte # Meeting detail page — renders view OR edit based on session flag │ │ └── +page.ts @@ -96,7 +95,7 @@ src/routes/idaa/ > 2. **Direct page** (`[event_id]/+page.svelte`) — navigating to `/idaa/recovery_meetings/` renders > the same view/edit components gated by `$idaa_sess.recovery_meetings.edit__event_obj`. > -> Both patterns use `ae_idaa_comp__event_obj_id_edit_v2.svelte`. The edit form clears **both** +> Both patterns use `ae_idaa_comp__event_obj_id_edit.svelte`. The edit form clears **both** > `show__modal_edit` and `edit__event_obj` on save/cancel so it works correctly from either entry point. --- diff --git a/documentation/TODO__Agents.md b/documentation/TODO__Agents.md index adf1f10c..16cf9d4b 100644 --- a/documentation/TODO__Agents.md +++ b/documentation/TODO__Agents.md @@ -23,7 +23,7 @@ Related: `src/lib/stores/store_versions.ts` is the new home for version constant - [x] **Minor Svelte warning:** `slct_event_location_id` in `menu_location_list.svelte` — prop already has `$bindable(null)`; stale comment in file updated. (2026-03-11) ### [Svelte] State reference warnings -- **42 `state_referenced_locally` warnings remain** in `recovery_meetings/ae_idaa_comp__event_obj_id_edit.svelte` and `..._v2.svelte`. Same pattern as the 10 fixed on 2026-03-09 — move reactive reads into `onMount`. +- [x] **`state_referenced_locally` warnings resolved** — all 42 warnings fixed. v1 edit form retired; v2 renamed to canonical name. Remaining 23 warnings in `ae_idaa_comp__event_obj_id_edit.svelte` are CSS `@apply`/`@reference` warnings from the svelte-check CSS language service not understanding Tailwind v4 at-rules — harmless, build works fine, not fixable without a full ` diff --git a/src/routes/idaa/(idaa)/recovery_meetings/ae_idaa_comp__event_obj_id_edit_v2.svelte b/src/routes/idaa/(idaa)/recovery_meetings/ae_idaa_comp__event_obj_id_edit_v2.svelte deleted file mode 100644 index 69e2ebc7..00000000 --- a/src/routes/idaa/(idaa)/recovery_meetings/ae_idaa_comp__event_obj_id_edit_v2.svelte +++ /dev/null @@ -1,2014 +0,0 @@ - - - - -
-
- - {#await prom_api__event_obj} -
- Saving... -
- {/await} - - - {#if $idaa_slct.event_id} -
- -
- {/if} - - -
-

- - Meeting Information -

- - - - - - - - -
- -
    -
  • IDAA — Open to IDAA members only
  • -
  • Caduceus — Open to all healthcare workers, including those who do not qualify for IDAA
  • -
  • Family Recovery — Open to spouses, parents, and adult children of medical professionals who have substance use disorder
  • -
-
-
- - -
-

- - How to Attend -

- - -
- Is this meeting in-person, virtual, or both? -
- - -
-
- - - - - {#if !$idaa_slct.event_obj?.physical} - - {/if} - -
-

- Physical Location -

- - - - -
- - - - - - - - - - - - - - - -
- - - -
- - - - - {#if !$idaa_slct.event_obj?.virtual} - - {/if} - -
-

- Virtual / Online -

- - -
-

Select the video platform for this meeting:

-
- - - -
-
- - - {#if $idaa_sess.recovery_meetings.attend_platform === 'Zoom' && $idaa_slct.event_obj.attend_json?.zoom} -
- - - - - -
- - - {:else if $idaa_sess.recovery_meetings.attend_platform === 'Jitsi'} -
- - - -
- - - {:else} -
- - - - -
- {/if} -
- - - -
- - -
-

- - Schedule -

- - - - - -
- Days of Week -
- {#each [ - { name: 'weekday_sunday', label: 'Sun' }, - { name: 'weekday_monday', label: 'Mon' }, - { name: 'weekday_tuesday', label: 'Tue' }, - { name: 'weekday_wednesday', label: 'Wed' }, - { name: 'weekday_thursday', label: 'Thu' }, - { name: 'weekday_friday', label: 'Fri' }, - { name: 'weekday_saturday', label: 'Sat' }, - ] as day (day.name)} - - {/each} -
-
- - -
- - - - - -
- - - {#if $ae_loc.administrator_access || ($lq__event_obj && ($idaa_slct.event_obj?.show_recurring_text || ($lq__event_obj?.recurring_text && !$lq__event_obj?.recurring_text.includes('*gen*'))))} -
- - -
- {:else} - - {/if} -
- - -
-

- - Contacts -

- - - - {#if $ae_loc.trusted_access} - - {:else} - - -
-

Meeting Owner

-
- - {#if $lq__event_obj?.external_person_full_name} - {$lq__event_obj.external_person_full_name} - {:else if $lq__event_obj?.external_person_email} - {$lq__event_obj.external_person_email} - {:else if $lq__event_obj?.external_person_id} - {$lq__event_obj.external_person_id} - {:else} - Not set - {/if} -
-
- {/if} - - - -
-
-

- Contact 1 (Primary) -

- {#if !$ae_loc.trusted_access && contact_1_locked} - - {:else if !$ae_loc.trusted_access && !contact_1_locked} - - {/if} -
- -
- - -
- -
- - - -
-
- - -
- - - {#if show_contact_2} -
- - -
- -
- - - -
- {:else} - - - - - - - {/if} -
-
- - - {#if $ae_loc.trusted_access} -
- - - {#if show_admin_options} - - - - -
- - - -
- - -
- - -
- - - - {:else} - - - - - - - - {/if} -
- {/if} - - -
- - - -
- - {#if $idaa_slct.event_id && $ae_loc.trusted_access} - {#if $ae_loc.administrator_access} - - - {/if} - - - {/if} - - - -
-
- -
-
- - diff --git a/tests/README.md b/tests/README.md index 5865e0ff..b1b8d20e 100644 --- a/tests/README.md +++ b/tests/README.md @@ -91,7 +91,7 @@ console.log(bad.map(el => el.name || el.id)); **Cause:** In Svelte 5, `value={someReactiveExpr}` on an uncontrolled `` or ` ← renders with value ✓