Scott.Idem/OSIT-AE-App-Svelte
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(launcher): use parent type_code for session_type, not per-file field

Browse Source 
The event_session_type_code field on file objects is often null, causing
poster-mode files to fall back to 'oral' and render as download buttons
instead of modal openers.

- launcher_session_view: session-level files now use derived type_code
- launcher_presenter_view: add session_type prop (default 'oral'); parent passes type_code
- launcher_presenter_view_posters: hardcode poster/modal (only ever rendered in poster context)
- launcher_menu event/location files unchanged: no session context, field is the only signal
This commit is contained in:
Scott Idem
2026-03-13 11:46:17 -04:00
parent c29ac9f9f5
commit 5f1169bb4c
3 changed files with 9 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/routes/events/[event_id]/(launcher)/launcher_presenter_view.svelte
View File

@@ -2,9 +2,10 @@
interface Props { interface Props {
// export let slct_event_presenter_id: string; // export let slct_event_presenter_id: string;
lq__event_presenter_obj: any; // This is not actually the LiveQuery object. This was pulled from the list of presenters for a presentation. With Svelte 5 this should not matter. lq__event_presenter_obj: any; // This is not actually the LiveQuery object. This was pulled from the list of presenters for a presentation. With Svelte 5 this should not matter.
session_type?: string;
} }
let { lq__event_presenter_obj }: Props = $props(); let { lq__event_presenter_obj, session_type = 'oral' }: Props = $props();
import type { key_val } from '$lib/stores/ae_stores'; import type { key_val } from '$lib/stores/ae_stores';
// import { ae_util } from '$lib/ae_utils/ae_utils'; // import { ae_util } from '$lib/ae_utils/ae_utils';
@@ -100,12 +101,8 @@
$events_loc.launcher.hide_content__draft_files $events_loc.launcher.hide_content__draft_files
} }
show_bak_download={$ae_loc.trusted_access} show_bak_download={$ae_loc.trusted_access}
session_type={event_file_obj?.event_session_type_code ?? session_type={session_type || 'oral'}
'oral'} open_method={session_type == 'poster' ? 'modal' : null}
open_method={event_file_obj?.event_session_type_code ==
'poster'
? 'modal'
: null}
modal_title={lq__event_presenter_obj?.event_presentation_name} modal_title={lq__event_presenter_obj?.event_presentation_name}
bind:modal__title={$events_sess.launcher.modal__title} bind:modal__title={$events_sess.launcher.modal__title}
bind:modal__open_event_file_id={ bind:modal__open_event_file_id={

8
src/routes/events/[event_id]/(launcher)/launcher_presenter_view_posters.svelte
View File

@@ -93,12 +93,8 @@
hide_created_on={false} hide_created_on={false}
hide_meta={true} hide_meta={true}
show_bak_download={$ae_loc.trusted_access} show_bak_download={$ae_loc.trusted_access}
session_type={event_file_obj?.event_session_type_code ?? session_type="poster"
'oral'} open_method="modal"
open_method={event_file_obj?.event_session_type_code ==
'poster'
? 'modal'
: null}
modal_title={lq__event_presenter_obj?.event_presentation_name} modal_title={lq__event_presenter_obj?.event_presentation_name}
bind:modal__title={$events_sess.launcher.modal__title} bind:modal__title={$events_sess.launcher.modal__title}
bind:modal__open_event_file_id={ bind:modal__open_event_file_id={

9
src/routes/events/[event_id]/(launcher)/launcher_session_view.svelte
View File

@@ -300,12 +300,8 @@
hide_created_on={true} hide_created_on={true}
show_bak_download={$ae_loc.trusted_access && show_bak_download={$ae_loc.trusted_access &&
$ae_loc.edit_mode} $ae_loc.edit_mode}
session_type={event_file_obj?.event_session_type_code ?? session_type={type_code || 'oral'}
'oral'} open_method={type_code == 'poster' ? 'modal' : null}
open_method={event_file_obj?.event_session_type_code ==
'poster'
? 'modal'
: null}
modal_title={$lq__event_session_obj?.name} modal_title={$lq__event_session_obj?.name}
bind:modal__title={ bind:modal__title={
$events_sess.launcher.modal__title $events_sess.launcher.modal__title
@@ -451,6 +447,7 @@
{:else} {:else}
<Launcher_presenter_view <Launcher_presenter_view
lq__event_presenter_obj={event_presenter_obj} lq__event_presenter_obj={event_presenter_obj}
session_type={type_code}
/> />
{/if} {/if}
</li> </li>