diff --git a/documentation/PROJECT__AE_Style_Review.md b/documentation/PROJECT__AE_Style_Review.md index 7f92efc6..e8f30da3 100644 --- a/documentation/PROJECT__AE_Style_Review.md +++ b/documentation/PROJECT__AE_Style_Review.md @@ -1,9 +1,9 @@ # PROJECT: Aether App β€” Comprehensive Style Review -**Status:** In Progress +**Status:** Phase 1 & 2 Complete β€” Phase 3 Deferred (post-April 2026 conference) **Priority:** Medium **Created:** 2026-03-13 -**Updated:** 2026-03-13 +**Updated:** 2026-03-16 **Related:** `src/app.css`, `src/routes/+layout.svelte`, `documentation/AE__UI_Component_Patterns.md` --- @@ -269,11 +269,12 @@ Key standard patterns: | Item | Status | Notes | |---|---|---| -| Root layout banners (offline, expired) | 🟑 Needs work | Uses `bg-orange-600/90` β€” replace with `preset-tonal-warning` | +| Root layout banners (offline, expired) | βœ… Done | `bg-orange-600/90` β†’ `preset-tonal-warning` (2026-03-16) | | `e_app_sys_bar.svelte` | βœ… Modern | Best-practice reference component | | `e_app_theme.svelte` | 🟑 Legacy | Redundant with sys_bar theme section; keep but no new work | -| `core/+layout.svelte` | βœ… Good | Uses `variant-soft-*` β€” migrate to `preset-*` eventually | +| `core/+layout.svelte` | βœ… Done | `variant-*` β†’ `preset-*` (2026-03-16) | | `core/+page.svelte` | βœ… Good | Excellent card grid template | +| All `/core/` files (21 files) | βœ… Done | `variant-*` β†’ `preset-*`, FA β†’ Lucide (2026-03-16) | ### Journals @@ -281,60 +282,62 @@ Key standard patterns: |---|---|---| | Overall | βœ… Canonical reference | Use as template for all new work | | `ae_comp__journal_obj_li.svelte` | βœ… Excellent | Card pattern, icon sizing, hover states | -| `ae_comp__journal_entry_obj_li.svelte` | 🟑 Minor issues | `bg-slate-*` inconsistency (should be `gray-*`); hardcoded HSL eye icon colors | -| `ae_comp__journal_entry_header.svelte` | πŸ”΄ A11y issue | `focus:ring-0` on name input β€” restore focus ring | +| `ae_comp__journal_entry_obj_li.svelte` | βœ… Done | `bg-slate-*` β†’ `bg-gray-*`; hardcoded HSL β†’ Tailwind tokens (2026-03-16) | +| `ae_comp__journal_entry_header.svelte` | βœ… Done | `focus:ring-0` restored to `focus:ring-2` (2026-03-16) | ### Events β€” General | Item | Status | Notes | |---|---|---| -| `events/+page.svelte` | 🟑 Legacy | FontAwesome icons; `variant-ghost-surface` button | -| `events/+layout.svelte` | 🟑 Legacy | FontAwesome spinners and arrows | -| `events/ae_comp__events_menu_nav.svelte` | 🟑 Legacy | All icons are FontAwesome | -| `events/[id]/+page.svelte` | 🟑 Mixed | Good card grid, but `variant-soft-warning` and hardcoded dark overrides | +| `events/+page.svelte` | βœ… Done | FA β†’ Lucide; `variant-ghost-surface` β†’ `preset-outlined-surface` (2026-03-16) | +| `events/+layout.svelte` | βœ… Done | FA β†’ Lucide (spinners, arrows) (2026-03-16) | +| `events/ae_comp__events_menu_nav.svelte` | βœ… Done | FA β†’ Lucide (2026-03-16) | +| `events/[id]/+page.svelte` | βœ… Done | FA β†’ Lucide; `variant-*` β†’ `preset-*` (2026-03-16) | +| `events/ae_comp__event_file_obj_tbl.svelte` | βœ… Done | FA β†’ Lucide (2026-03-16) | +| `events/ae_comp__event_presentation_obj_li.svelte` | βœ… Done | FA β†’ Lucide (2026-03-16) | +| Lucide inline flow | βœ… Done | Global `svg.lucide { display: inline }` rule in `app.css` (2026-03-16) | ### Events β€” Pres Mgmt | Item | Status | Notes | -|---|---|---| -| Overall | 🟑 Legacy | Predates the modern refactor | -| `pres_mgmt/+page.svelte` | 🟑 Legacy | FontAwesome throughout; bare list, no card styling | -| Session/presenter page menus | 🟑 Legacy | FontAwesome icons; `variant-*` buttons | -| Session view | 🟑 Mixed | Some modern patterns mixed with legacy | +| --- | --- | --- | +| All 24 pres_mgmt files | βœ… Done | FA β†’ Lucide; `variant-*` β†’ `preset-*` (2026-03-16) | +| Card styling for session/presenter lists | πŸ”’ Phase 3 | Deferred to post-April 2026 | ### Events β€” Launcher ⚠️ Live Production | Item | Status | Notes | -|---|---|---| +| --- | --- | --- | | Overall | ⚠️ FREEZE | **April 2026 conference** β€” no style changes until post-event | | Icon/button migration | πŸ”’ Deferred | Schedule for Phase 3 after conference | +| `launcher_session_view.svelte:329` | πŸ”’ Frozen | One `variant-soft-secondary` remains β€” do not touch | ### Events β€” Badges | Item | Status | Notes | -|---|---|---| -| Overall | 🟑 Mixed | Functional, some `variant-*` patterns | -| `badge_upload_form.svelte` | 🟑 Legacy | `variant-filled-tertiary/primary` buttons | -| `badge_template_form.svelte` | 🟑 Legacy | `variant-filled-*` buttons | +| --- | --- | --- | +| FA β†’ Lucide | βœ… Done | All badge files migrated (2026-03-16) | +| `badge_upload_form.svelte` | βœ… Done | `variant-*` β†’ `preset-*` (2026-03-16) | +| `badge_template_form.svelte` | βœ… Done | `variant-*` β†’ `preset-*` (2026-03-16) | +| `code_to_html` | βœ… Refactored | FA HTML string dict β†’ `code_to_icon` Lucide component map (2026-03-16) | ### Events β€” Leads | Item | Status | Notes | -|---|---|---| -| Overall | 🟑 Legacy | Heavy `variant-*` usage throughout; otherwise functionally good | -| `ae_comp__exhibit_signin.svelte` | 🟑 Mixed | `variant-filled-primary`, `variant-soft-error` | -| `ae_comp__lead_qr_scanner.svelte` | 🟑 Legacy | All state cards use `variant-soft-*` | -| `ae_tab__add.svelte` | 🟑 Legacy | `variant-filled-secondary`, `variant-ghost-surface` tab buttons | +| --- | --- | --- | +| FA β†’ Lucide | βœ… Done | All leads files migrated (2026-03-16) | +| `ae_comp__exhibit_signin.svelte` | βœ… Done | `variant-*` β†’ `preset-*` (2026-03-16) | +| `ae_comp__lead_qr_scanner.svelte` | βœ… Done | `variant-*` β†’ `preset-*` (2026-03-16) | +| `ae_tab__add.svelte` | βœ… Done | `variant-*` β†’ `preset-*` (2026-03-16) | ### IDAA ⚠️ Privacy-Critical | Item | Status | Notes | -|---|---|---| +| --- | --- | --- | | `(idaa)/+page.svelte` | βœ… Modern | Semantic tokens, good access gate | -| Archives | 🟑 Partial | Likely legacy underneath; deferred | -| BB (Posts) | 🟑 Partial | Deferred β€” most sensitive module | -| Recovery Meetings | 🟑 Partial | Deferred | -| **All IDAA** | ⚠️ Last priority | Review only after non-IDAA modules are complete | +| FA CDN | βœ… Scoped | Moved from `app.html` β†’ `idaa/+layout.svelte` `` (2026-03-16) | +| Archives, BB, Recovery Meetings | πŸ”’ Deferred | Full style review deferred to Phase 3 | +| **All IDAA FA β†’ Lucide** | πŸ”’ Last priority | Review only after non-IDAA modules are complete | --- diff --git a/documentation/TODO__Agents.md b/documentation/TODO__Agents.md index 55bf4dee..cf233dee 100644 --- a/documentation/TODO__Agents.md +++ b/documentation/TODO__Agents.md @@ -75,6 +75,7 @@ lead record look like in the DB? - **Input Field Audit:** Several input fields are missing `name`/`id` attributes or `data-testid`. Known examples: badge override fields in `ae_comp__badge_obj_view.svelte`; template name input in `ae_comp__badge_template_form.svelte`. Matters for: accessibility, autofill, label associations, and test targeting. (For tests, use `getByLabel()` rather than `input[value*=...]` which only checks the HTML attribute, not the Svelte-bound DOM property.) ## βœ… Completed (2026-03) +- [x] **[UI]** Style Review Phase 1 & 2 complete β€” all non-frozen, non-IDAA routes migrated: FAβ†’Lucide (events, pres_mgmt, core, badges, leads, hosted_files), `variant-*`β†’`preset-*` (all modules), `code_to_html` badge dict refactored to Lucide component map, FA CDN scoped to IDAA layout, global `svg.lucide { display: inline }` CSS rule added to fix icon inline flow. See `documentation/PROJECT__AE_Style_Review.md`. (2026-03-16) - [x] **[UI]** Pres Mgmt Phase 3 β€” FAβ†’Lucide icon migration across all 24 pres_mgmt files. (2026-03-16) - [x] **[IDAA]** `ae_idaa_comp__event_obj_id_edit.svelte` β€” inlined Tailwind utilities, removed `