Scott.Idem/OSIT-AE-API-FastAPI
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Finally returning correct HTTP status codes

Browse Source
This commit is contained in:
Scott Idem
2021-08-10 19:06:40 -04:00
parent a1b9d3c518
commit cfd85435f2
29 changed files with 83 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
app/routers/api_crud.py
View File

@@ -184,22 +184,22 @@ async def get_obj_li(
if obj_name in obj_type_li:
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
elif obj_type_l1 and obj_type_l2:
obj_name = f'{obj_type_l1}_{obj_type_l2}'
if obj_name in obj_type_li:
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
elif obj_type_l1:
obj_name = f'{obj_type_l1}'
if obj_name in obj_type_li:
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
else:
log.warning('We should not be here')
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
table_name = obj_type_li[obj_name]['table_name']
@@ -280,24 +280,24 @@ async def get_obj(
#table_name = obj_type_li[obj_name]['table_name']
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
elif obj_type_l1 and obj_type_l2:
obj_name = f'{obj_type_l1}_{obj_type_l2}'
if obj_name in obj_type_li:
#table_name = obj_type_li[obj_name]['table_name']
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
elif obj_type_l1:
obj_name = f'{obj_type_l1}'
if obj_name in obj_type_li:
#table_name = obj_type_li[obj_name]['table_name']
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
else:
log.warning('We should not be here')
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
table_name = obj_type_li[obj_name]['table_name']
@@ -355,22 +355,22 @@ async def delete_obj(
if obj_name in obj_type_li:
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
elif obj_type_l1 and obj_type_l2:
obj_name = f'{obj_type_l1}_{obj_type_l2}'
if obj_name in obj_type_li:
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
elif obj_type_l1:
obj_name = f'{obj_type_l1}'
if obj_name in obj_type_li:
pass
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
else:
log.warning('We should not be here')
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
table_name = obj_name # obj_type_li[obj_name]['table_name'] # NOTE: Don't try to use the view!
@@ -410,7 +410,7 @@ def post_obj_template(
else:
log.setLevel(logging.DEBUG) # DEBUG, INFO, WARNING, ERROR, EXCEPTION, CRITICAL
log.debug(sql_insert_result)
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
if sql_select_result := sql_select(table_name=table_name_select, record_id=obj_id):
log.debug(sql_select_result)
@@ -456,7 +456,7 @@ def patch_obj_template(
else:
log.setLevel(logging.DEBUG) # DEBUG, INFO, WARNING, ERROR, EXCEPTION, CRITICAL
log.debug(sql_update_result)
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=400, response=response)
if sql_select_result := sql_select(table_name=table_name_select, record_id=obj_id):
log.debug(sql_select_result)
@@ -534,7 +534,7 @@ def get_obj_template(
if obj_id:
sql_result = sql_select(table_name=table_name_select, record_id=obj_id)
else:
return mk_resp(data=False, status_code=400)
return mk_resp(data=False, status_code=404, response=response)
if sql_result:
log.debug(sql_result)