Scott.Idem/OSIT-AE-API-FastAPI
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor Journal and Journal Entry models to strictly use Vision ID string pattern

Browse Source 
Updated Journal_Base and Journal_Entry_Base to explicitly remove integer IDs (journal_id, journal_entry_id) during validation to prevent mixed-type ID collisions. This ensures the Journal module adheres to the highest V3 Vision standard compliance.
This commit is contained in:
Scott Idem
2026-01-27 13:00:22 -05:00
parent 007fd2ec8f
commit 3311ba8dd6
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/journal_entry_models.py
View File

@@ -130,7 +130,7 @@ class Journal_Entry_Base(BaseModel):
values['parent_id'] = p_rid values['parent_id'] = p_rid
# 2. Prevent "Collision Population" # 2. Prevent "Collision Population"
for k in ['id', 'journal_id', 'account_id', 'parent_id']: for k in ['id', 'journal_entry_id', 'journal_id', 'account_id', 'parent_id']:
if k in values and not isinstance(values[k], str): if k in values and not isinstance(values[k], str):
del values[k] del values[k]

2
app/models/journal_models.py
View File

@@ -147,7 +147,7 @@ class Journal_Base(BaseModel):
values['user_id'] = u_rid values['user_id'] = u_rid
# 2. Prevent "Collision Population" # 2. Prevent "Collision Population"
for k in ['id', 'account_id', 'person_id', 'user_id']: for k in ['id', 'journal_id', 'account_id', 'person_id', 'user_id']:
if k in values and not isinstance(values[k], str): if k in values and not isinstance(values[k], str):
del values[k] del values[k]