From 3311ba8dd62098cbc89947e5f0c9f15080787e47 Mon Sep 17 00:00:00 2001 From: Scott Idem Date: Tue, 27 Jan 2026 13:00:22 -0500 Subject: [PATCH] Refactor Journal and Journal Entry models to strictly use Vision ID string pattern Updated Journal_Base and Journal_Entry_Base to explicitly remove integer IDs (journal_id, journal_entry_id) during validation to prevent mixed-type ID collisions. This ensures the Journal module adheres to the highest V3 Vision standard compliance. --- app/models/journal_entry_models.py | 2 +- app/models/journal_models.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/journal_entry_models.py b/app/models/journal_entry_models.py index db0bb88..2c4de42 100644 --- a/app/models/journal_entry_models.py +++ b/app/models/journal_entry_models.py @@ -130,7 +130,7 @@ class Journal_Entry_Base(BaseModel): values['parent_id'] = p_rid # 2. Prevent "Collision Population" - for k in ['id', 'journal_id', 'account_id', 'parent_id']: + for k in ['id', 'journal_entry_id', 'journal_id', 'account_id', 'parent_id']: if k in values and not isinstance(values[k], str): del values[k] diff --git a/app/models/journal_models.py b/app/models/journal_models.py index 1fcb723..a6f2eab 100644 --- a/app/models/journal_models.py +++ b/app/models/journal_models.py @@ -147,7 +147,7 @@ class Journal_Base(BaseModel): values['user_id'] = u_rid # 2. Prevent "Collision Population" - for k in ['id', 'account_id', 'person_id', 'user_id']: + for k in ['id', 'journal_id', 'account_id', 'person_id', 'user_id']: if k in values and not isinstance(values[k], str): del values[k]